Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different prevention of duplicate test PyPI uploads #15

Merged
merged 1 commit into from
May 17, 2020

Commits on May 17, 2020

  1. Different prevention of duplicate test PyPI uploads

    If not triggered by a tag-create event, delete all tags pointing to the
    current commit so that it is always treated as a development version.
    
    This prevents a race condition where a commit tagged soon after being
    pushed may or may either end on on test PyPI as a .dev version *and* a
    release, or only the latter, depending on timing. If there is a matrix
    of jobs running, which of these happens could be different for each job,
    leading to some platforms having an extra dev version on test PyPI that
    others platforms don't.
    
    This makes it deterministic: unless we're in a tag event, don't use any
    tags from the current commit, and determine the version from previous
    tags only.
    
    And we can get rid of the if statement that was designed to prevent
    duplicate PyPI uploads.
    chrisjbillington committed May 17, 2020
    Configuration menu
    Copy the full SHA
    b922bc6 View commit details
    Browse the repository at this point in the history