Different prevention of duplicate test PyPI uploads #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If not triggered by a tag-create event, delete all tags pointing to the current commit so that it is always treated as a development version. This prevents a race condition where a commit tagged soon after being pushed may or may either end on on test PyPI as a .dev version *and* a release, or only the latter, depending on timing. If there is a matrix of jobs running, which of these happens could be different for each job, leading to some platforms having an extra dev version on test PyPI that others platforms don't. This makes it deterministic: unless we're in a tag event, don't use any tags from the current commit, and determine the version from previous tags only. And we can get rid of the if statement that was designed to prevent duplicate PyPI uploads.
|
If github-actions fix actions/checkout#249, we can hopefully then just delete the |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not triggered by a tag-create event, delete all tags pointing to the
current commit so that it is always treated as a development version.
This prevents a race condition where a commit tagged soon after being
pushed may either end on on test PyPI as a .dev version and a
release, or only the latter, depending on timing. If there is a matrix
of jobs running, which of these happens could be different for each job,
leading to some platforms having an extra dev version on test PyPI that
others platforms don't.
This makes it deterministic: unless we're in a tag event, don't use any
tags from the current commit, and determine the version from previous
tags only.
And we can get rid of the if statement that was designed to prevent
duplicate PyPI uploads.
Relevant: #10, #13