Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose .idl to DDS .idl conversion via rosidl translate CLI #55

Merged
merged 3 commits into from
Mar 10, 2021

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Feb 26, 2021

Connected to ros2/rosidl#565. Depends on ros2/rosidl#575.

@hidmic hidmic requested a review from sloretz February 26, 2021 21:07
@hidmic hidmic mentioned this pull request Feb 26, 2021
21 tasks
@hidmic hidmic force-pushed the hidmic/rosidl-translate-dds-idl branch from 5bc231d to 36f6362 Compare March 1, 2021 23:54
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic force-pushed the hidmic/rosidl-translate-dds-idl branch from 36f6362 to 1242d04 Compare March 9, 2021 14:59
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@ahcorde
Copy link

ahcorde commented Mar 9, 2021

The CI job needs a release https://build.ros2.org/job/Rpr__rosidl_dds__ubuntu_focal_amd64/5/ for rosidl_cli, right ?

@ahcorde
Copy link

ahcorde commented Mar 9, 2021

@osrf-jenkins retest this please

@hidmic
Copy link
Contributor Author

hidmic commented Mar 9, 2021

The CI job needs a release https://build.ros2.org/job/Rpr__rosidl_dds__ubuntu_focal_amd64/5/ for rosidl_cli, right ?

Indeed!

Edit: ros/rosdistro#28525 is up

@hidmic hidmic requested a review from ahcorde March 9, 2021 21:15
@ahcorde
Copy link

ahcorde commented Mar 10, 2021

@osrf-jenkins retest this please

@hidmic
Copy link
Contributor Author

hidmic commented Mar 10, 2021

Running CI up to rosidl_generator_dds_idl:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Mar 10, 2021

Re-running Windows CI after 4bbea01:

  • Windows Build Status

@hidmic
Copy link
Contributor Author

hidmic commented Mar 10, 2021

Alright, CI's green, reviewer is OK with this patch. Going in!

@hidmic hidmic merged commit 43cea40 into master Mar 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the hidmic/rosidl-translate-dds-idl branch March 10, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants