Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding wildcard package-name default #369

Closed
wants to merge 1 commit into from

Conversation

SteveMacenski
Copy link

@SteveMacenski SteveMacenski commented Jan 9, 2024

Closes #368

@SteveMacenski SteveMacenski requested a review from a team as a code owner January 9, 2024 18:34
@SteveMacenski SteveMacenski requested review from gbiggs and jhdcs and removed request for a team January 9, 2024 18:34
@christophebedard
Copy link
Member

Thanks for the quick PR! I think it would be good to add a workflow step here to test the default value: https://github.com/ros-tooling/action-ros-lint/blob/master/.github/workflows/test.yml. Existing test steps are under both test_setup_ros and test_setup_ros_docker so just add it to both.

Also, please sign-off the commit to appease the DCO bot.

@SteveMacenski
Copy link
Author

SteveMacenski commented Jan 9, 2024

Honestly, I don't have the cycles this month to go into too much detail here unfortunately. This was a thing I did on my phone at lunch between meetings :/ This month is a real shitshow.

Also, please sign-off the commit to appease the DCO bot.

I noticed that. If you go to settings -> check the box that says Require contributors to sign off on web-based commits, it'll let users edit files from the UI and have DCO checks succeed with a remark in the commit box about signing off. That would be a QOL for contributors and recently added to Nav2 as well 😄

@christophebedard christophebedard self-assigned this Jan 9, 2024
@christophebedard
Copy link
Member

Honestly, I don't have the cycles this month to go into too much detail here unfortunately. This was a thing I did on my phone at lunch between meetings :/ This month is a real shitshow.

No worries. I just got back from vacation so I have a bunch of stuff to catch up on myself, but I'll get to it. Appreciate the effort.

I noticed that. If you go to settings -> check the box that says Require contributors to sign off on web-based commits, it'll let users edit files from the UI and have DCO checks succeed with a remark in the commit box about signing off. That would be a QOL for contributors and recently added to Nav2 as well 😄

Done!

@christophebedard
Copy link
Member

christophebedard commented May 11, 2024

@SteveMacenski just checking, is this a change you're still interested in? If so, I can revive this PR or create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package-name required for linting large metapackage project
2 participants