Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for invalid file name patterns #4556

Merged
merged 2 commits into from
Jul 8, 2022
Merged

Improve error message for invalid file name patterns #4556

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c73fd9d
Improve error message for invalid patterns
DysphoricUnicorn Jul 7, 2022
e6f4e7a
Merge branch 'master' into improve-pattern-path-error-message
lukastaegert Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/renderNamePattern.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export function renderNamePattern(
if (isPathFragment(pattern))
return error(
errFailedValidation(
`Invalid pattern "${pattern}" for "${patternName}", patterns can be neither absolute nor relative paths.`
`Invalid pattern "${pattern}" for "${patternName}", patterns can be neither absolute nor relative paths. If you want your files to be stored in a subdirectory, write its name without a leading slash like this: subdirectory/pattern.`
)
);
return pattern.replace(/\[(\w+)\]/g, (_match, type) => {
Expand Down
2 changes: 1 addition & 1 deletion test/function/samples/invalid-pattern/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ module.exports = {
generateError: {
code: 'VALIDATION_ERROR',
message:
'Invalid pattern "../main.js" for "output.entryFileNames", patterns can be neither absolute nor relative paths.'
'Invalid pattern "../main.js" for "output.entryFileNames", patterns can be neither absolute nor relative paths. If you want your files to be stored in a subdirectory, write its name without a leading slash like this: subdirectory/pattern.'
}
};