Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for invalid file name patterns #4556

Conversation

DysphoricUnicorn
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no
  • existing test has been updated

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

Description

This error message felt really confusing to me and even while reading the documentation, it was unclear how I could get my entries to be stored in a sub directory.
I added this little hint to the error message so that others may not run into the same issue.

This error message felt really confusing to me and even while reading
the documentation, it was unclear how I could get my entries to be
stored in a subdirectory. I added this little hint to the error message
so that others may not run into the same issue.
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I like these kind of contributions 👍

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #4556 (e6f4e7a) into master (2e2a659) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4556   +/-   ##
=======================================
  Coverage   98.88%   98.89%           
=======================================
  Files         208      208           
  Lines        7282     7332   +50     
  Branches     2081     2094   +13     
=======================================
+ Hits         7201     7251   +50     
  Misses         26       26           
  Partials       55       55           
Impacted Files Coverage Δ
src/utils/renderNamePattern.ts 100.00% <ø> (ø)
cli/run/batchWarnings.ts 99.18% <0.00%> (-0.82%) ⬇️
src/Bundle.ts 100.00% <0.00%> (ø)
src/utils/transform.ts 100.00% <0.00%> (ø)
cli/run/waitForInput.ts 100.00% <0.00%> (ø)
src/utils/FileEmitter.ts 100.00% <0.00%> (ø)
src/utils/pluginUtils.ts 100.00% <0.00%> (ø)
src/utils/PluginDriver.ts 100.00% <0.00%> (ø)
src/utils/PluginContext.ts 100.00% <0.00%> (ø)
src/ast/nodes/MetaProperty.ts 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b399ff...e6f4e7a. Read the comment docs.

@lukastaegert lukastaegert enabled auto-merge (squash) July 8, 2022 04:30
@lukastaegert lukastaegert merged commit 4bab4ac into rollup:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants