Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix comment regarding invalid annotation handling #4081

Merged
merged 1 commit into from May 15, 2021
Merged

fix comment regarding invalid annotation handling #4081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/utils/pureComments.ts
View file
Open in desktop
Expand Up @@ -32,8 +32,11 @@ function isOnlyWhitespaceOrComments(code: string) {
const ast = acorn.parse(code, { ecmaVersion: 'latest' }) as any;
return ast.body && ast.body.length === 0;
} catch {
// should never be reached -
// the entire module was previously successfully parsed
// should only be reached by invalid annotations like:
//
// foo() /*@__PURE__*/ /* other */, bar();
//
// where `code` is " /* other */, "
}
return false;
}
Expand Down