Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comment regarding invalid annotation handling #4081

Merged
merged 1 commit into from May 15, 2021
Merged

fix comment regarding invalid annotation handling #4081

merged 1 commit into from May 15, 2021

Conversation

kzc
Copy link
Contributor

@kzc kzc commented May 14, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

#4068

Description

Fix comment in #4068 and add an example of an invalid annotation.
No code changes.

@github-actions
Copy link

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install kzc/rollup#fix-comment-for-invalid-annotation

or load it into the REPL:
https://rollupjs.org/repl/?pr=4081

@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Merging #4081 (e575d47) into master (2bee261) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4081   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         193      193           
  Lines        6818     6824    +6     
  Branches     2002     2005    +3     
=======================================
+ Hits         6647     6653    +6     
  Misses         84       84           
  Partials       87       87           
Impacted Files Coverage Δ
src/Graph.ts 100.00% <100.00%> (ø)
src/utils/pureComments.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40d206...e575d47. Read the comment docs.

@lukastaegert lukastaegert merged commit 7457478 into rollup:master May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants