Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add node.js v16 support #4071

Merged
merged 2 commits into from May 14, 2021
Merged

chore: add node.js v16 support #4071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eddc004
chore: add node.js v16 support
dnalborczyk May 7, 2021
033cd23
Merge branch 'master' into node-16
dnalborczyk May 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Expand Up @@ -71,7 +71,7 @@ jobs:
runs-on: windows-2019
strategy:
matrix:
node: ['14', '12', '10']
node: ['10', '12', '14', '16']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current versions are placed first since they run faster. that makes any errors reported during tests faster to report, which reduces wait time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it appears to be a common usage pattern I have seen to use an ascending order, incl. in the GH actions docs. that said, I didn't know that there was a purpose behind the order in this repo, but I looked at some sample data and that statement is simply not [always consistently] true - or better, if anything, it's randomly true, e.g.: https://github.com/rollup/rollup/runs/2211099843 since each GH action pod I assume does not always get the same exact resources assigned.

anyhow, if needed, I can change it back to descending order.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it does not matter then, thanks for checking!

name: Node ${{ matrix.node }} (Windows)
steps:
- name: Configure git line-breaks
Expand Down