Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add node.js v16 support #4071

Merged
merged 2 commits into from May 14, 2021
Merged

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented May 7, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@github-actions
Copy link

github-actions bot commented May 7, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install dnalborczyk/rollup#node-16

or load it into the REPL:
https://rollupjs.org/repl/?pr=4071

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #4071 (033cd23) into master (2bee261) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4071   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         193      193           
  Lines        6818     6818           
  Branches     2002     2002           
=======================================
  Hits         6647     6647           
  Misses         84       84           
  Partials       87       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bee261...033cd23. Read the comment docs.

@@ -71,7 +71,7 @@ jobs:
runs-on: windows-2019
strategy:
matrix:
node: ['14', '12', '10']
node: ['10', '12', '14', '16']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current versions are placed first since they run faster. that makes any errors reported during tests faster to report, which reduces wait time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it appears to be a common usage pattern I have seen to use an ascending order, incl. in the GH actions docs. that said, I didn't know that there was a purpose behind the order in this repo, but I looked at some sample data and that statement is simply not [always consistently] true - or better, if anything, it's randomly true, e.g.: https://github.com/rollup/rollup/runs/2211099843 since each GH action pod I assume does not always get the same exact resources assigned.

anyhow, if needed, I can change it back to descending order.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it does not matter then, thanks for checking!

@lukastaegert lukastaegert merged commit 3345267 into rollup:master May 14, 2021
@dnalborczyk dnalborczyk deleted the node-16 branch May 17, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants