Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow environment variables to contain colons #3283

Merged
merged 3 commits into from Dec 14, 2019
Merged

Allow environment variables to contain colons #3283

merged 3 commits into from Dec 14, 2019

Commits on Dec 13, 2019

  1. Allow environment variables to contain colons 

    Currently, any environment variables that have colon in them are discarded, including any text following them. This pr includes them.

**Before:**
```
URL:http://localhost:4200 =  ['URL', 'http']
```

**After:**
```
URL:http://localhost:4200 =  ['URL', 'http://localhost:4200']
```

**Example:**
https://jsbin.com/mexeyifuqi/1/edit?js,console
    @tlaverdure
    tlaverdure committed Dec 13, 2019
    Copy the full SHA
    c725825 View commit details
    Browse the repository at this point in the history

  2. Add test.

    @tlaverdure
    tlaverdure committed Dec 13, 2019
    Copy the full SHA
    8cfac88 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2019

  1. Update conditional that sets env variables.

    @tlaverdure
    tlaverdure committed Dec 14, 2019
    Copy the full SHA
    b18e745 View commit details
    Browse the repository at this point in the history