New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow environment variables to contain colons #3283
Conversation
Currently, any environment variables that have colon in them are discarded, including any text following them. This pr includes them. **Before:** ``` URL:http://localhost:4200 = ['URL', 'http'] ``` **After:** ``` URL:http://localhost:4200 = ['URL', 'http://localhost:4200'] ``` **Example:** https://jsbin.com/mexeyifuqi/1/edit?js,console
Codecov Report
@@ Coverage Diff @@
## master #3283 +/- ##
==========================================
- Coverage 94.45% 93.12% -1.33%
==========================================
Files 170 170
Lines 8027 5967 -2060
Branches 2780 1780 -1000
==========================================
- Hits 7582 5557 -2025
+ Misses 287 219 -68
- Partials 158 191 +33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for spotting and fixing, I wonder why this did not turn up earlier. Happy to merge and release this when you are done from your side.
Thanks! Should be all set now. |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
Environment variables may include colons. Currently if one does they are removed along with any text following.
Before:
After:
Example:
https://jsbin.com/zizexetuqu/edit?js,console