Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow environment variables to contain colons #3283

Merged
merged 3 commits into from Dec 14, 2019

Conversation

tlaverdure
Copy link
Contributor

@tlaverdure tlaverdure commented Dec 13, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Environment variables may include colons. Currently if one does they are removed along with any text following.

Before:

URL:http://localhost:4200 =  ['URL', 'http']

After:

URL:http://localhost:4200 =  ['URL', 'http://localhost:4200']

Example:
https://jsbin.com/zizexetuqu/edit?js,console

Currently, any environment variables that have colon in them are discarded, including any text following them. This pr includes them.

**Before:**
```
URL:http://localhost:4200 =  ['URL', 'http']
```

**After:**
```
URL:http://localhost:4200 =  ['URL', 'http://localhost:4200']
```

**Example:**
https://jsbin.com/mexeyifuqi/1/edit?js,console
@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #3283 into master will decrease coverage by 1.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3283      +/-   ##
==========================================
- Coverage   94.45%   93.12%   -1.33%     
==========================================
  Files         170      170              
  Lines        8027     5967    -2060     
  Branches     2780     1780    -1000     
==========================================
- Hits         7582     5557    -2025     
+ Misses        287      219      -68     
- Partials      158      191      +33
Impacted Files Coverage Δ
cli/run/index.ts 86.79% <100%> (ø) ⬆️
src/utils/path.ts 66.66% <0%> (-13.34%) ⬇️
src/utils/renderChunk.ts 85% <0%> (-11.16%) ⬇️
src/finalisers/shared/setupNamespace.ts 90% <0%> (-10%) ⬇️
src/ast/nodes/Property.ts 92.3% <0%> (-7.7%) ⬇️
src/ast/scopes/BlockScope.ts 80% <0%> (-5.72%) ⬇️
src/watch/fileWatchers.ts 85.71% <0%> (-5.6%) ⬇️
browser/path.ts 76.92% <0%> (-5.43%) ⬇️
src/utils/timers.ts 59.09% <0%> (-4.87%) ⬇️
src/ast/nodes/AssignmentExpression.ts 95.23% <0%> (-4.77%) ⬇️
... and 139 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5502ad...b18e745. Read the comment docs.

@tlaverdure tlaverdure marked this pull request as ready for review December 13, 2019 19:19
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for spotting and fixing, I wonder why this did not turn up earlier. Happy to merge and release this when you are done from your side.

cli/run/index.ts Outdated Show resolved Hide resolved
@tlaverdure
Copy link
Contributor Author

Thanks! Should be all set now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants