Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference url in error messages #3033

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/run/batchWarnings.ts
Expand Up @@ -156,7 +156,7 @@ const deferredHandlers: {
MISSING_EXPORT: {
fn: warnings => {
title('Missing exports');
info('https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module-');
info('https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module');

warnings.forEach(warning => {
stderr(tc.bold(warning.importer as string));
Expand Down
2 changes: 1 addition & 1 deletion src/Module.ts
Expand Up @@ -156,7 +156,7 @@ function handleMissingExport(
{
code: 'MISSING_EXPORT',
message: `'${exportName}' is not exported by ${relativeId(importedModule)}`,
url: `https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module-`
url: `https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module`
},
importerStart as number
);
Expand Down
2 changes: 1 addition & 1 deletion src/ast/nodes/MemberExpression.ts
Expand Up @@ -303,7 +303,7 @@ export default class MemberExpression extends NodeBase implements DeoptimizableE
importer: relativeId(this.context.fileName),
message: `'${exportName}' is not exported by '${relativeId(fileName)}'`,
missing: exportName,
url: `https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module-`
url: `https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module`
},
path[0].pos
);
Expand Down
2 changes: 1 addition & 1 deletion test/function/samples/default-not-reexported/_config.js
Expand Up @@ -17,6 +17,6 @@ module.exports = {
2:
3: console.log( def );
`,
url: `https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module-`
url: `https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module`
}
};
Expand Up @@ -33,6 +33,6 @@ module.exports = {
2:
3: Object.assign({}, a);
`,
url: `https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module-`
url: `https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module`
}
};
Expand Up @@ -17,6 +17,6 @@ module.exports = {
2:
3: a();
`,
url: `https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module-`
url: `https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module`
}
};
2 changes: 1 addition & 1 deletion test/function/samples/namespace-missing-export/_config.js
Expand Up @@ -22,7 +22,7 @@ module.exports = {
3: assert.equal( typeof mod.foo, 'undefined' );
^
`,
url: `https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module-`
url: `https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module`
}
]
};
2 changes: 1 addition & 1 deletion test/function/samples/reexport-missing-error/_config.js
Expand Up @@ -15,6 +15,6 @@ module.exports = {
1: export { foo as bar } from './empty.js';
^
`,
url: 'https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module-'
url: 'https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module'
}
};