Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference url in error messages #3033

Merged

Conversation

giraffate
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Update existing tests.

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

Description

Remove an unneeded trailing hyphen (-) from reference url in error messages.

Before: https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module-
After: https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module

@codecov
Copy link

codecov bot commented Aug 6, 2019

Codecov Report

Merging #3033 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3033   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files         165      165           
  Lines        5694     5694           
  Branches     1738     1738           
=======================================
  Hits         5048     5048           
  Misses        388      388           
  Partials      258      258
Impacted Files Coverage Δ
src/ast/nodes/MemberExpression.ts 95.37% <ø> (ø) ⬆️
src/Module.ts 94.19% <ø> (ø) ⬆️
cli/run/batchWarnings.ts 25.61% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a61d3...55cd11f. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks! Reminds me that I wanted to extract these URLs at some point to be able to run an automated test if they all actually exist on the website... 🙄

@lukastaegert lukastaegert merged commit a243d14 into rollup:master Aug 6, 2019
@giraffate giraffate deleted the fix_reference_url_in_error_messages branch August 6, 2019 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants