Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong file extension #3031

Merged
merged 1 commit into from Aug 5, 2019
Merged

Fix wrong file extension #3031

merged 1 commit into from Aug 5, 2019

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

The location of the binary had wrongly a file extension appended

@lukastaegert lukastaegert mentioned this pull request Aug 5, 2019
Closed
@lukastaegert lukastaegert merged commit 81c4869 into master Aug 5, 2019
@lukastaegert lukastaegert deleted the fix-bin-extension branch August 5, 2019 18:52
alan-agius4
alan-agius4 suggested changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the dist/bin in filesunder package.json

@alan-agius4
Copy link
Contributor

At the moment only .js and .d.ts files are included.

  "files": [
    "dist/**/*.js",
    "dist/*.d.ts"
  ]

Aditya-Viswanadha
Aditya-Viswanadha reviewed Aug 5, 2019
View reviewed changes
Copy link

@Aditya-Viswanadha Aditya-Viswanadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

styfle added a commit to styfle/rollup that referenced this pull request Aug 5, 2019
@styfle
Add dist/bin/** to published files
c57a1fc 
Follow up to rollup#3031

Fixes rollup#3029
@styfle styfle mentioned this pull request Aug 5, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aditya-Viswanadha Aditya-Viswanadha Aditya-Viswanadha left review comments

@alan-agius4 alan-agius4 alan-agius4 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukastaegert @alan-agius4 @Aditya-Viswanadha