Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path to rollup binary #3030

Closed
wants to merge 1 commit into from
Closed

Conversation

alan-agius4
Copy link
Contributor

FIxes: #3029

@styfle
Copy link
Contributor

styfle commented Aug 5, 2019

I don't think this won't work. The file needs to start with #!/usr/bin/env node.

Also compare the two files:

https://unpkg.com/browse/rollup@1.18.0/bin/rollup

https://unpkg.com/browse/rollup@1.19.0/dist/rollup.js

@shellscape shellscape self-requested a review August 5, 2019 18:44
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #3030 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3030   +/-   ##
=======================================
  Coverage   88.65%   88.65%           
=======================================
  Files         165      165           
  Lines        5694     5694           
  Branches     1738     1738           
=======================================
  Hits         5048     5048           
  Misses        388      388           
  Partials      258      258

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9af119d...a3a1fce. Read the comment docs.

@alan-agius4 alan-agius4 closed this Aug 5, 2019
@lukastaegert
Copy link
Member

Thanks, but this is not the correct file, see
#3031

@alan-agius4 alan-agius4 deleted the patch-3 branch August 5, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm ERR! enoent ENOENT: no such file or directory, rollup/dist/bin/rollup.js
4 participants