Regression in 1.14.0 with imports and unused parameters

[mikeharder]

• Rollup Version: Regression introduced in 1.14.0, still repros in 1.16.2
• Operating System (or Browser): Windows 10
• Node Version: 10.16.0

Overview

If an imported function and unused parameter have the same name, rollup@1.13.1 renames the parameter which generates a valid bundle, while rollup@1.14.0 (and rollup@1.16.2) does not rename the parameter which causes a runtime error. I believe this is a regression introduced by #2892.

How Do We Reproduce?

// log.js
export const context = console.log;


// main.js
import * as log from "./log";

function test(context) {
  log.context("hello");
}

test();

Expected Behavior

REPL

> npm install --global rollup@1.13.1
> rollup main.js --format cjs

'use strict';

const context = console.log;

function test(context$1) {
  context("hello");
}

test();

Actual Behavior

REPL

> npm install --global rollup@1.14.0
> rollup main.js --format cjs

'use strict';

const context = console.log;

function test(context) {
  context("hello");
}

test();

[lukastaegert]

Thanks for spotting this, fix at #2972