Fix filter parameter shadowing on locateIn

[gzzo]

The signature of locateIn includes a filter that is not used in the current definition of the function. This is causing some issues during the bundling on master for me. This is what locateIn and `locate ends up looking like:

    var locateVisible = function (container, current, selector) {
      return locateIn(container, current, selector);
    };
    var locateIn = function (container, current, selector, filter) {
      var predicate = curry(eq, current);
      var candidates = descendants(container, selector);
      var visible = filter(candidates, isVisible);
      return locate$2(visible, predicate);
    };

Note that the filter argument in locateVisible is removed, probably because the bundler can tell that the argument goes unused. Then locateIn calls filter from its argument list, which shadows the original Arr.filter, causing a filter is not a function error.

This is what the same block looks like from this branch:

    var locateVisible = function (container, current, selector) {
      var filter = isVisible;
      return locateIn(container, current, selector, filter);
    };
    var locateIn = function (container, current, selector, filter$1) {
      var predicate = curry(eq, current);
      var candidates = descendants(container, selector);
      var visible = filter(candidates, filter$1);
      return locate$2(visible, predicate);
    };

[TheSpyder]

Thank you for highlighting this issue and finding a workaround.

This was caused by upgrading rollup last week before rollup/rollup#2970 was fixed. It has wider implications, we'll be upgrading rollup again to include the fix and doing a new release of TinyMCE shortly.

[gzzo]

@TheSpyder Why not merge it? locateIn still has an unused argument in its signature that isn't used, regardless of rollup. Surprised lint doesn't catch this.

[TheSpyder]

Our lint settings don't check for unused arguments at the moment. I didn't merge this because I was focussed on the critical issue in the release, which upgrading rollup fixed, not whether your change had other benefits.

Looking at the larger picture locateIn isn't even used directly so I might just inline it. Thanks for the reminder :)