[Event Hubs] Test Issues with Rollup 1.14.0

[chradek]

Running the node integration tests in the @azure/event-hubs package throws connection-related errors for most tests that reach out over the network.

Steps to reproduce

1. rush update
2. rush build -t @azure/event-hubs
3. cd into sdk/eventhub/event-hubs directory
4. Create .env file in sdk/eventhub/event-hubs directory
5. Generate test build: rushx build:test
6. Run node integration tests: rushx integration-test:node

Findings

We believe the root cause is a regression in rollup@1.14.0: rollup/rollup#2970. This should be fixed in rollup@1.16.3: https://github.com/rollup/rollup/blob/master/CHANGELOG.md#1163.

TypeScript

// log.ts
export const context = debugModule("azure:event-hubs:connectionContext");


// connectionContext.ts
import * as log from "./log";

const onConnectionOpen: OnAmqpEvent = (context: EventContext) => {
   connectionContext.wasConnectionCloseCalled = false;
      log.context(
        "[%s] setting 'wasConnectionCloseCalled' property of connection context to %s.",
        connectionContext.connection.id,
        connectionContext.wasConnectionCloseCalled
      );
    };

ESM (valid)

// log.js
export const context = debugModule("azure:event-hubs:connectionContext");

// connectionContext.js
import * as log from "./log";

const onConnectionOpen = (context) => {
    connectionContext.wasConnectionCloseCalled = false;
    log.context("[%s] setting 'wasConnectionCloseCalled' property of connection context to %s.", connectionContext.connection.id, connectionContext.wasConnectionCloseCalled);
};

rollup@1.13.1 - CJS (valid)

const onConnectionOpen = (context$1) => {
    connectionContext.wasConnectionCloseCalled = false;
    context("[%s] setting 'wasConnectionCloseCalled' property of connection context to %s.", connectionContext.connection.id, connectionContext.wasConnectionCloseCalled);
};

rollup@1.14.0 - CJS (invalid)

const onConnectionOpen = (context) => {
    connectionContext.wasConnectionCloseCalled = false;
    context("[%s] setting 'wasConnectionCloseCalled' property of connection context to %s.", connectionContext.connection.id, connectionContext.wasConnectionCloseCalled);
};

Test Failures

1) Create EventHubClient #RunnableInBrowser
     creates an EventHubClient from an Azure.Identity credential:
   Uncaught Unhandled error. ({ _context:
 TypeError: context is not a function
     at Connection.onConnectionOpen (/home/vsts/work/1/s/sdk/eventhub/event-hubs/test-dist/index.js:12812:13)
     at Connection.emit (events.js:198:13)
     at emit (/home/vsts/work/1/s/common/temp/node_modules/.registry.npmjs.org/rhea-promise/0.1.15/node_modules/rhea-promise/dist/lib/util/utils.js:129:24)
     at Object.emitEvent (/home/vsts/work/1/s/common/temp/node_modules/.registry.npmjs.org/rhea-promise/0.1.15/node_modules/rhea-promise/dist/lib/util/utils.js:140:9)
     at Connection._connection.on (/home/vsts/work/1/s/common/temp/node_modules/.registry.npmjs.org/rhea-promise/0.1.15/node_modules/rhea-promise/dist/lib/connection.js:378:25)
     at Connection.emit (events.js:203:15)
     at Connection.dispatch (/home/vsts/work/1/s/common/temp/node_modules/.registry.npmjs.org/rhea/1.0.7/node_modules/rhea/lib/connection.js:242:37)
     at Connection.on_open (/home/vsts/work/1/s/common/temp/node_modules/.registry.npmjs.org/rhea/1.0.7/node_modules/rhea/lib/connection.js:640:14)
     at c.dispatch (/home/vsts/work/1/s/common/temp/node_modules/.registry.npmjs.org/rhea/1.0.7/node_modules/rhea/lib/types.js:909:33)
     at Transport.read (/home/vsts/work/1/s/common/temp/node_modules/.registry.npmjs.org/rhea/1.0.7/node_modules/rhea/lib/transport.js:108:36)
     at SaslClient.read (/home/vsts/work/1/s/common/temp/node_modules/.registry.npmjs.org/rhea/1.0.7/node_modules/rhea/lib/sasl.js:299:26)
     at Connection.input (/home/vsts/work/1/s/common/temp/node_modules/.registry.npmjs.org/rhea/1.0.7/node_modules/rhea/lib/connection.js:501:35)
     at TLSSocket.emit (events.js:198:13)
     at addChunk (_stream_readable.js:288:12)
     at readableAddChunk (_stream_readable.js:269:11)
     at TLSSocket.Readable.push (_stream_readable.js:224:10)
     at TLSWrap.onStreamRead [as onread] (internal/stream_base_commons.js:94:17),

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=57447

[chradek]

Narrowed it down to version 1.14.0 of rollup breaks our build. This was released earlier today. Version 1.13.1 works as expected.

[chradek]

We should also check if other packages are impacted, specifically service bus.

[chradek]

Narrowed the symtpom to a single parameter in connectionContext being renamed when generating the test build using rollup. The version in dist-esm is correct.