Disable pessimistic object deoptimization for calls when the called f…

…unction doesn't ref this (#4011)

* Disable pessimistic object deoptimization for calls when the called function doesn't ref this

Issue #3989

* Use a base class for special-purpose value objects

To avoid duplicating all ExpressionEntity methods for every object.

* Remove toString for values

* Move function Node initialization to parseNode

* Also handle arrow functions

Co-authored-by: Lukas Taegert-Atkinson <lukas.taegert-atkinson@tngtech.com>
Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>

src/ast/nodes/ArrowFunctionExpression.ts

@@ -98,6 +98,10 @@ export default class ArrowFunctionExpression extends NodeBase {
 		}
 	}
 
+	mayModifyThisWhenCalledAtPath() {
+		return false;
+	}
+
 	parseNode(esTreeNode: GenericEsTreeNode) {
 		if (esTreeNode.body.type === NodeType.BlockStatement) {
 			this.body = new this.context.nodeConstructors.BlockStatement(

src/ast/nodes/CallExpression.ts

@@ -65,7 +65,8 @@ export default class CallExpression extends NodeBase implements DeoptimizableEnt
 		// ensure the returnExpression is set for the tree-shaking passes
 		this.getReturnExpression(SHARED_RECURSION_TRACKER);
 		// This deoptimizes "this" for non-namespace calls until we have a better solution
-		if (this.callee instanceof MemberExpression && !this.callee.variable) {
+		if (this.callee instanceof MemberExpression && !this.callee.variable &&
+		    this.callee.mayModifyThisWhenCalledAtPath([])) {
 			this.callee.object.deoptimizePath(UNKNOWN_PATH);
 		}
 		for (const argument of this.arguments) {

src/ast/nodes/Identifier.ts

@@ -141,6 +141,12 @@ export default class Identifier extends NodeBase implements PatternNode {
 		this.variable!.includeCallArguments(context, args);
 	}
 
+	mayModifyThisWhenCalledAtPath(
+		path: ObjectPath
+	) {
+		return this.variable ? this.variable.mayModifyThisWhenCalledAtPath(path) : true
+	}
+
 	render(
 		code: MagicString,
 		_options: RenderOptions,

src/ast/nodes/MemberExpression.ts

@@ -233,6 +233,15 @@ export default class MemberExpression extends NodeBase implements DeoptimizableE
 		this.propertyKey = getResolvablePropertyKey(this);
 	}
 
+	mayModifyThisWhenCalledAtPath(
+		path: ObjectPath
+	) {
+		if (this.variable) {
+			return this.variable.mayModifyThisWhenCalledAtPath(path);
+		}
+		return this.object.mayModifyThisWhenCalledAtPath([this.propertyKey as ObjectPathKey].concat(path));
+	}
+
 	render(
 		code: MagicString,
 		options: RenderOptions,

src/ast/nodes/ObjectExpression.ts

@@ -256,6 +256,16 @@ export default class ObjectExpression extends NodeBase implements DeoptimizableE
 		return false;
 	}
 
+	mayModifyThisWhenCalledAtPath(
+		path: ObjectPath
+	) {
+		if (!path.length || typeof path[0] !== "string") {
+			return true;
+		}
+		const property = this.getPropertyMap()[path[0]]?.exactMatchRead;
+		return property ? property.value.mayModifyThisWhenCalledAtPath(path.slice(1)) : true;
+	}
+
 	render(
 		code: MagicString,
 		options: RenderOptions,

src/ast/nodes/ThisExpression.ts

@@ -4,6 +4,7 @@ import ModuleScope from '../scopes/ModuleScope';
 import { ObjectPath } from '../utils/PathTracker';
 import ThisVariable from '../variables/ThisVariable';
 import * as NodeType from './NodeType';
+import FunctionNode from './shared/FunctionNode';
 import { NodeBase } from './shared/Node';
 
 export default class ThisExpression extends NodeBase {
@@ -38,6 +39,12 @@ export default class ThisExpression extends NodeBase {
 				this.start
 			);
 		}
+		for (let parent = this.parent; parent instanceof NodeBase; parent = parent.parent) {
+			if (parent instanceof FunctionNode) {
+				parent.referencesThis = true;
+				break;
+			}
+		}
 	}
 
 	render(code: MagicString) {

src/ast/nodes/shared/Expression.ts

@@ -33,4 +33,7 @@ export interface ExpressionEntity extends WritableEntity {
 	): boolean;
 	include(context: InclusionContext, includeChildrenRecursively: IncludeChildren): void;
 	includeCallArguments(context: InclusionContext, args: (ExpressionNode | SpreadElement)[]): void;
+	mayModifyThisWhenCalledAtPath(
+		path: ObjectPath
+	): boolean;
 }

src/ast/nodes/shared/FunctionNode.ts

@@ -16,6 +16,7 @@ export default class FunctionNode extends NodeBase {
 	id!: IdentifierWithVariable | null;
 	params!: PatternNode[];
 	preventChildBlockScope!: true;
+	referencesThis!: boolean;
 	scope!: FunctionScope;
 
 	private isPrototypeDeoptimized = false;
@@ -120,7 +121,14 @@ export default class FunctionNode extends NodeBase {
 		this.body.addImplicitReturnExpressionToScope();
 	}
 
+	mayModifyThisWhenCalledAtPath(
+		path: ObjectPath
+	) {
+		return path.length ? true : this.referencesThis
+	}
+
 	parseNode(esTreeNode: GenericEsTreeNode) {
+		this.referencesThis = false;
 		this.body = new this.context.nodeConstructors.BlockStatement(
 			esTreeNode.body,
 			this,

src/ast/nodes/shared/MultiExpression.ts

@@ -73,4 +73,8 @@ export class MultiExpression implements ExpressionEntity {
 	}
 
 	includeCallArguments(): void {}
+
+	mayModifyThisWhenCalledAtPath(path: ObjectPath) {
+		return this.expressions.some(e => e.mayModifyThisWhenCalledAtPath(path));
+	}
 }

src/ast/nodes/shared/Node.ts

@@ -229,6 +229,12 @@ export class NodeBase implements ExpressionNode {
 		}
 	}
 
+	mayModifyThisWhenCalledAtPath(
+		_path: ObjectPath
+	) {
+		return true
+	}
+
 	parseNode(esTreeNode: GenericEsTreeNode) {
 		for (const key of Object.keys(esTreeNode)) {
 			// That way, we can override this function to add custom initialisation and then call super.parseNode