Skip to content

Commit

Permalink
Use SIGTERM instead of SIGINT to kill test child processes (#4015)
Browse files Browse the repository at this point in the history
Since SIGINT fails to actually kill them on some platforms under some circumstances,
leading to a whole lot of watch tests sitting around for 40 seconds until they
time out.

See derail in the discussion for issue #3989
  • Loading branch information
marijnh authored and lukastaegert committed Mar 27, 2021
1 parent 497637e commit ecdae30
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/cli/index.js
Expand Up @@ -124,10 +124,10 @@ runTestSuiteWithSamples(
if (config.abortOnStderr) {
try {
if (await config.abortOnStderr(data)) {
childProcess.kill('SIGINT');
childProcess.kill('SIGTERM');
}
} catch (err) {
childProcess.kill('SIGINT');
childProcess.kill('SIGTERM');
done(err);
}
}
Expand Down

0 comments on commit ecdae30

Please sign in to comment.