Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass dependencies from preprocessor response through in transform plugin #40

Closed
Conduitry opened this issue Nov 20, 2018 · 2 comments
Closed

Comments

@Conduitry
Copy link
Member

It would be nice for preprocessing to be able to make use of the feature available in Rollup 0.61+ that lets transforms specify additional files as dependencies, so that watching works properly.

This will be slightly fiddly as we'll have to intercept the responses from the markup/style/script callbacks to grab the dependencies from them, before passing the response along to svelte.preprocess. Then we'll compile the component (as we do now), and finally include those gathered dependencies in the response from the transform hook.

@Conduitry
Copy link
Member Author

Conduitry commented Nov 20, 2018

Opened PR #41. Still needs some readme updates to reflect the new feature. Probably passable docs now included.

Rich-Harris added a commit that referenced this issue Dec 15, 2018
Pass through dependencies from preprocessor
@Rich-Harris
Copy link
Member

closed via #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants