Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through dependencies from preprocessor #41

Merged
merged 6 commits into from
Dec 15, 2018
Merged

Pass through dependencies from preprocessor #41

merged 6 commits into from
Dec 15, 2018

Conversation

Conduitry
Copy link
Member

@Conduitry Conduitry commented Nov 20, 2018

Implements #40. No doc updates yet.

@Conduitry
Copy link
Member Author

Added some docs. Having a separate section for this feels a bit clunky. Not thrilled with that, but it seems like too much stuff to try to cram into a code comment alongside the preprocess example.

@Conduitry
Copy link
Member Author

Conduitry commented Nov 20, 2018

Possible weird stuff is afoot. Hold off on merging. We're cool now, I'm bad at brain.

@Conduitry
Copy link
Member Author

Resolved merge conflict (which somehow git rebase could take care automatically, but GitHub couldn't?) and also fixed the test so that it passes under Svelte 3 as well.

@Rich-Harris Rich-Harris merged commit dd4f86c into sveltejs:master Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants