Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track dependent files in @minna-ui/pre-style util #211

Merged
merged 3 commits into from
Dec 16, 2018
Merged

Track dependent files in @minna-ui/pre-style util #211

merged 3 commits into from
Dec 16, 2018

Conversation

maxmilton
Copy link
Member

@maxmilton maxmilton commented Dec 16, 2018 •
edited

Now that sveltejs/rollup-plugin-svelte#40 is fixed, we can use the new rollup dependencies tracking functionality.

This change allows rollup to trigger a rebuild when in watch mode and a dependency changes.

@maxmilton
Track dependent files in pre-style
3a738dc 
This allows rollup to trigger a rebuild when in watch mode and a dependency changes.
@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   73.53%   73.53%           
=======================================
  Files          30       30           
  Lines         427      427           
  Branches       98       99    +1     
=======================================
  Hits          314      314           
  Misses         89       89           
  Partials       24       24
Impacted Files Coverage Δ
utils/rollup-plugins/lib/makeCss.js 0% <ø> (ø) ⬆️
utils/pre-style/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a812442...3a738dc. Read the comment docs.

6 similar comments
@codecov
Copy link

codecov bot commented Dec 16, 2018 •
edited

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   73.53%   73.53%           
=======================================
  Files          30       30           
  Lines         427      427           
  Branches       98       99    +1     
=======================================
  Hits          314      314           
  Misses         89       89           
  Partials       24       24
Impacted Files Coverage Δ
utils/rollup-plugins/lib/makeCss.js 0% <ø> (ø) ⬆️
utils/pre-style/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a812442...3a738dc. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   73.53%   73.53%           
=======================================
  Files          30       30           
  Lines         427      427           
  Branches       98       99    +1     
=======================================
  Hits          314      314           
  Misses         89       89           
  Partials       24       24
Impacted Files Coverage Δ
utils/rollup-plugins/lib/makeCss.js 0% <ø> (ø) ⬆️
utils/pre-style/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a812442...3a738dc. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   73.53%   73.53%           
=======================================
  Files          30       30           
  Lines         427      427           
  Branches       98       99    +1     
=======================================
  Hits          314      314           
  Misses         89       89           
  Partials       24       24
Impacted Files Coverage Δ
utils/rollup-plugins/lib/makeCss.js 0% <ø> (ø) ⬆️
utils/pre-style/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a812442...3a738dc. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   73.53%   73.53%           
=======================================
  Files          30       30           
  Lines         427      427           
  Branches       98       99    +1     
=======================================
  Hits          314      314           
  Misses         89       89           
  Partials       24       24
Impacted Files Coverage Δ
utils/rollup-plugins/lib/makeCss.js 0% <ø> (ø) ⬆️
utils/pre-style/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a812442...3a738dc. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 16, 2018

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   73.53%   73.53%           
=======================================
  Files          30       30           
  Lines         427      427           
  Branches       98       99    +1     
=======================================
  Hits          314      314           
  Misses         89       89           
  Partials       24       24
Impacted Files Coverage Δ
utils/rollup-plugins/lib/makeCss.js 0% <ø> (ø) ⬆️
utils/pre-style/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a812442...3a738dc. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 16, 2018 •
edited

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #211   +/-   ##
=======================================
  Coverage   73.53%   73.53%           
=======================================
  Files          30       30           
  Lines         427      427           
  Branches       98       99    +1     
=======================================
  Hits          314      314           
  Misses         89       89           
  Partials       24       24
Impacted Files Coverage Δ
utils/rollup-plugins/lib/makeCss.js 0% <ø> (ø) ⬆️
utils/pre-style/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a812442...3a738dc. Read the comment docs.

@maxmilton maxmilton changed the title Track dependent files in pre-style Track dependent files in @minna-ui/pre-style util Dec 16, 2018
@maxmilton maxmilton merged commit 41a1fd1 into master Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@maxmilton