feat(terser): parallel execution

[tada5hi]

Rollup Plugin Name: terser

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:
1334

Description

Execute minify process in parallel

[shellscape]

Thanks for opening this one. Is this based on existing work somewhere or brand new work? If existing, please document from where so we have a reference point. If it's new, please add some code comments for code in spots you think people may have questions or that may raise eyebrows.

[tada5hi]

Thanks for opening this one. Is this based on existing work somewhere or brand new work? If existing, please document from where so we have a reference point. If it's new, please add some code comments for code in spots you think people may have questions or that may raise eyebrows.

The idea of merging and populating the nameCache of a sub process is from @TrySound, but it is only the idea not the code. Nevertheless, i already mentioned him in the Readme.
The rest is completly concepted and implemented by myself.

[shellscape]

That was less about attribution and more about helping the other maintainers understand the change.

[tada5hi]

That was less about attribution and more about helping the other maintainers understand the change.

No problem 😊
If you or anyone else have any questions, I'm more than happy to help ✌️ 😇

[michaelfaith]

That was less about attribution and more about helping the other maintainers understand the change.

No problem 😊 If you or anyone else have any questions, I'm more than happy to help ✌️ 😇

I think the request was for more documentation / comment blocks.

[tada5hi]

@shellscape can you check if everything is fine now?
If something is still missing or should be enhanced, let me know.
Greetings
Peter

[shellscape]

@TrySound please have a look through this one. once merged, it will probably be a good idea to deprecate the other plugin (https://www.npmjs.com/package/rollup-plugin-terser) and archive the old repo, pointing people here. If you need a hand with that, please feel free to add me to each and I'll take care of it.

[tada5hi]

@shellscape is TrySound's feedback required or how long do you plan to wait for his review?

What's weird is that I'm not listed as a contributor for the initial work on the plugin.
https://github.com/rollup/plugins/graphs/contributors
Is this because of the strategy you used to merge my commits?

[shellscape]

It may be that Github doesn't update that in realtime. You're also on the merge commit. 2d67e34. I wouldn't get too wrapped up with vanity metrics.

You should however add yourself to https://github.com/rollup/plugins/blob/master/CODEOWNERS for this plugin so you get automated notifications when someone opens a PR against it.

is TrySound's feedback required or how long do you plan to wait for his review?

I would like it, yes. he's a busy guy so it may take some time. moving forward that won't be the case.

[shellscape]

Welp. It's been a week so we'll move forward. Thanks for your patience.

[jakearchibald]

This caused a regression by using __filename in a module #1366.

[tada5hi]

It may be that Github doesn't update that in realtime. You're also on the merge commit. 2d67e34. I wouldn't get too wrapped up with vanity metrics.

You should however add yourself to https://github.com/rollup/plugins/blob/master/CODEOWNERS for this plugin so you get automated notifications when someone opens a PR against it.

is TrySound's feedback required or how long do you plan to wait for his review?

I would like it, yes. he's a busy guy so it may take some time. moving forward that won't be the case.

@shellscape no problem. I was just wondering 😅
Good point. I added myself to the list in the recent pull request.