Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid re-running ICU ./configure if Makefile exists #6889

Merged
merged 2 commits into from Nov 29, 2021

Commits on Nov 29, 2021

  1. Avoid re-running ICU ./configure if Makefile exists

    Unnecessarily re-running ICU configure is costly -- it takes around
    10-20s by itself, and it also invalidates some build artifacts, which
    results in 'make' having to do work.
    
    This makes running `./gradlew :nativeruntime:processResources` much,
    much faster (18s -> 2.5s on my machine) after ICU has been built.
    
    Also, improve the error message when ICU configure is run on an
    unsupported OS.
    hoisie committed Nov 29, 2021
    Copy the full SHA
    3913bb1 View commit details
    Browse the repository at this point in the history
  2. Improve nativeruntime skipping logic

    Previously, the logic to handle SKIP_NATIVERUNTIME_BUILD in
    processResources was in a Gradle 'onlyIf' block, which meant that the
    'makeNativeRuntime' task still ran.
    
    Update the nativeruntie processResources task to also skip running
    `makeNativeRuntime` if SKIP_NATIVERUNTIME_BUILD is set to true.
    hoisie committed Nov 29, 2021
    Copy the full SHA
    1b2c9af View commit details
    Browse the repository at this point in the history