Avoid re-running ICU ./configure if Makefile exists #6889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utzcoz
approved these changes
Nov 29, 2021
utzcoz
reviewed
Nov 29, 2021
utzcoz
approved these changes
Nov 29, 2021
|
Looks like "validate gradle wrapper" action timeout. It is not a problem. We can omit it for this PR. |
hoisie
force-pushed
the
skip-configure
branch
from
25fb895
to
e4bb53a
Compare
Unnecessarily re-running ICU configure is costly -- it takes around 10-20s by itself, and it also invalidates some build artifacts, which results in 'make' having to do work. This makes running `./gradlew :nativeruntime:processResources` much, much faster (18s -> 2.5s on my machine) after ICU has been built. Also, improve the error message when ICU configure is run on an unsupported OS.
Previously, the logic to handle SKIP_NATIVERUNTIME_BUILD in processResources was in a Gradle 'onlyIf' block, which meant that the 'makeNativeRuntime' task still ran. Update the nativeruntie processResources task to also skip running `makeNativeRuntime` if SKIP_NATIVERUNTIME_BUILD is set to true.
hoisie
force-pushed
the
skip-configure
branch
from
e4bb53a
to
1b2c9af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes running
./gradlew :nativeruntime:processResourcesmuch,much faster after ICU has been built.