Set DirectiveDefinitionNode.children_method_name #4931
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4928.
This commit sets
DirectiveDefinitionNode.children_method_name
to:definitions
. It previously defaulted to:directive_definitions
, causing aNoMethodError
when attempting to delete the node from the AST.I wasn't sure how best to test this, so I added some directive definitions to the SDL test case in the visitor spec. Let me know if there's a more suitable way.