Merge pull request #4931 from thomasmarshall/fix-directive-definition

Set DirectiveDefinitionNode.children_method_name
rmosolgo · Apr 23, 2024 · 0799211 · 0799211
2 parents 43bbe01 + 221db86
commit 0799211
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/graphql/language/nodes.rb b/lib/graphql/language/nodes.rb
@@ -362,6 +362,7 @@ class DirectiveDefinition < AbstractNode
           arguments: Nodes::Argument,
           locations: Nodes::DirectiveLocation,
         )
+        self.children_method_name = :definitions
       end
 
       # An enum value. The string is available as {#name}.

diff --git a/spec/graphql/language/visitor_spec.rb b/spec/graphql/language/visitor_spec.rb
@@ -200,6 +200,14 @@ def on_variable_definition(node, parent)
           super
         end
       end
+
+      def on_directive_definition(node, parent)
+        if node.name == "deleteMe"
+          super(DELETE_NODE, parent)
+        else
+          super
+        end
+      end
     end
 
     def get_result(query_str)
@@ -375,6 +383,10 @@ def get_result(query_str)
 
     it "works with SDL" do
       before_query = <<-GRAPHQL.chop
+directive @deleteMe on FIELD
+
+directive @keepMe on FIELD
+
 type Rename @doStuff {
   f: Int
   renameThis: String
@@ -383,6 +395,8 @@ def get_result(query_str)
 GRAPHQL
 
       after_query = <<-GRAPHQL.chop
+directive @keepMe on FIELD
+
 type WasRenamed @doStuff(addedArgument2: 2) {
   f: Int
   wasRenamed: String