Fixes for #3228 (playground dev crash), #3213 (Ajv8 additionalProperties validation) #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix vite dev server - Assign `globalThis` to window.global to fix issue in semantic - ajv-formats `addFormats` should not be called with a nullish value
nickgros
commented
Nov 4, 2022
nickgros
commented
Nov 4, 2022
Playground - Playground `localValidator` should use @rjsf/validator-ajv8 - Upgrade Vite and @vitejs/plugin-react to latest @rjsf/validator-ajv8 - Alias `ajv` to `ajv8` because in the playground, Vite erroneously imports Ajv 6 - Report any schema error thrown by Ajv - Disable Ajv's strict mode by default - Add RJSF-specific additional properties keywords to Ajv to prevent errors from being reported in strict mode. -
nickgros
force-pushed
the
fix-vite-dev-server
branch
from
122e258
to
82dfc8d
Compare
nickgros
changed the title
nickgros
commented
Nov 5, 2022
| @@ -27,13 +27,13 @@ | |||
| ] | |||
| }, | |||
| "dependencies": { | |||
| "ajv": "^8.11.0", | |||
| "ajv8": "npm:ajv@^8.11.0", | |||
There was a problem hiding this comment.
Part of the reason the dev server was crashing was because Vite was resolving 'ajv' to Ajv 6 in '@rjsf/validator-ajv8'. I could not find a Vite/esbuild configuration option to handle this (maybe it's a bug?). This fixes the issue.
Will this affect anything for users?
There was a problem hiding this comment.
Maybe switch things in the ajv6 validator instead?
There was a problem hiding this comment.
The fix doesn't work if I just change it for ajv6, not sure why.
| "@rjsf/utils": "^5.0.0-beta.1" | ||
| "@rjsf/utils": "^5.0.0-beta.12" |
There was a problem hiding this comment.
I think you can revert this one since the ^ will get it to .12
heath-freenome
approved these changes
Nov 5, 2022
4 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3228, #3213
Playground
localValidatorshould use @rjsf/validator-ajv8@rjsf/validator-ajv8
ajvtoajv8because in the playground, Vite erroneously imports Ajv 6Checklist
npm run test:updateto update snapshots, if needed.