Undo ajv8 alias and fix Vite dev server #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Let's merge #3372 first then rebase this one. Hopefully the |
nickgros
force-pushed
the
fix-ajv-alias-dev-server
branch
from
4bfc645
to
15ad520
Compare
- Upgrade vite to 4.0.4 - Remove ajv8 alias for validator-ajv8 (will fix issues in skypack) - Change vite mode to production (fixes issue where vite/esbuild mix up ajv v6 and v8)
nickgros
force-pushed
the
fix-ajv-alias-dev-server
branch
from
15ad520
to
511aa21
Compare
heath-freenome
approved these changes
Jan 14, 2023
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
* Re-fix rjsf-team#3228 and related follow-up issues - Upgrade vite to 4.0.4 - Remove ajv8 alias for validator-ajv8 (will fix issues in skypack) - Change vite mode to production (fixes issue where vite/esbuild mix up ajv v6 and v8) * Update lockfile * `preserveSymlinks` seems to fix rather than changing `mode` * Update CHANGELOG
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
* Re-fix rjsf-team#3228 and related follow-up issues - Upgrade vite to 4.0.4 - Remove ajv8 alias for validator-ajv8 (will fix issues in skypack) - Change vite mode to production (fixes issue where vite/esbuild mix up ajv v6 and v8) * Update lockfile * `preserveSymlinks` seems to fix rather than changing `mode` * Update CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
truein vite.config.js (fixes issue in Vite dev server where @rjsf/validator-ajv8 incorrectly uses ajv@6)Reasons for making this change
Fixes #3215
We have an issue where the Vite development server is accessing files from ajv v6 when it should be using ajv v8. It's unclear if this is a Vite/esbuild bug, or some configuration error.
We originally fixed this in #3229, but this solution has caused other downstream issues (e.g. Skypack, which is used in CodePen examples, cannot handle npm aliases).
Setting the Vite config
preserveSymlinksparameter totrueseems to fix this issue.Checklist
npm run test:updateto update snapshots, if needed.