Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/checkout from 2 to 2.3.4 #3362

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 12, 2021

Bumps actions/checkout from 2 to 2.3.4.

Release notes

Sourced from actions/checkout's releases.

v2.3.4

v2.3.3

v2.3.2

Add Third Party License Information to Dist Files

v2.3.1

Fix default branch resolution for .wiki and when using SSH

v2.3.0

Fallback to the default branch

v2.2.0

Fetch all history for all tags and branches when fetch-depth=0

v2.1.1

Changes to support GHES (here and here)

v2.1.0

Changelog

Sourced from actions/checkout's changelog.

Changelog

v2.3.1

v2.3.0

v2.2.0

v2.1.1

  • Changes to support GHES (here and here)

v2.1.0

v2.0.0

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 2.3.4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v2.3.4)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot temporarily deployed to staging May 12, 2021 05:51 Inactive
@dependabot dependabot bot temporarily deployed to staging May 12, 2021 05:51 Inactive
@VladimirSlavik VladimirSlavik added the infrastructure Changes affecting mostly infrastructure label May 12, 2021
@VladimirSlavik VladimirSlavik self-assigned this May 12, 2021
@VladimirSlavik
Copy link
Contributor

Needs amending commit messages with #infra. Not sure if we need to re-run all the things. Maybe we should.

Release notes mention fetch-depth: 0 now takes everything, which changes things for us. So far we used 0 to get just the last commit and speed up checkouts. Maybe we should bump these to 1 in our workflows, just in case. The change is presumably meant to better reflect git's behavior - it does not allow 0, "last commit" is 1.

@VladimirSlavik
Copy link
Contributor

VladimirSlavik commented May 12, 2021

@jkonecny12 mentioned that version of 1 should take latest 1.whatever. Maybe we're already fine?

It could be that dependabot does not understand 1, while 1.x would shut it up. See how we do it for the requests action from octokit. That syntax is not mentioned in the docs, though...

@jkonecny12
Copy link
Member

/kickstart-test --testtype smoke

@github-actions
Copy link

Requested workflow run has to be approved. You can do that here

@jkonecny12
Copy link
Member

Needs amending commit messages with #infra. Not sure if we need to re-run all the things. Maybe we should.

Release notes mention fetch-depth: 0 now takes everything, which changes things for us. So far we used 0 to get just the last commit and speed up checkouts. Maybe we should bump these to 1 in our workflows, just in case. The change is presumably meant to better reflect git's behavior - it does not allow 0, "last commit" is 1.

We're already using the fetch-depth as checkout everything. We need that because rebase needs to know whole history and the other branches too.

@jkonecny12 jkonecny12 added the blocked Don't merge this pull request! label May 12, 2021
@jkonecny12
Copy link
Member

I'm setting blocked label until questions in this PR are answered: #3366

@jkonecny12
Copy link
Member

Closing with explanation in #3366 .

@jkonecny12 jkonecny12 closed this May 17, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 17, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/github_actions/actions/checkout-2.3.4 branch May 17, 2021 11:16
@jkonecny12
Copy link
Member

@dependabot recreate

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 17, 2021

Looks like this PR is closed. If you re-open it I'll rebase it as long as no-one else has edited it (you can use @dependabot reopen if the branch has been deleted).

@jkonecny12
Copy link
Member

@dependabot reopen

@dependabot dependabot bot reopened this May 17, 2021
@dependabot dependabot bot restored the dependabot/github_actions/actions/checkout-2.3.4 branch May 17, 2021 11:17
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 17, 2021

Looks like actions/checkout is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this May 17, 2021
@dependabot dependabot bot deleted the dependabot/github_actions/actions/checkout-2.3.4 branch May 17, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Don't merge this pull request! infrastructure Changes affecting mostly infrastructure
2 participants