consume new @actions/github for GHES support #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
commented
May 7, 2020
| @@ -75,8 +74,8 @@ async function downloadArchive( | |||
| ref: string, | |||
| commit: string | |||
| ): Promise<Buffer> { | |||
| const octokit = new github.GitHub(authToken, {baseUrl: urlHelper.getApiUrl()}) | |||
| const params: ReposGetArchiveLinkParams = { | |||
| const octokit = new github.GitHub(authToken) | |||
There was a problem hiding this comment.
Let the toolkit set the baseUrl
ericsciple
commented
May 7, 2020
| import {default as uuid} from 'uuid/v4' | ||
| import {ReposGetArchiveLinkParams} from '@octokit/rest' | ||
| import {Octokit} from '@octokit/rest' |
There was a problem hiding this comment.
wasnt able to import directly anymore (compat break)
This was referenced Mar 6, 2021
This was referenced Mar 14, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the toolkit set the baseUrl (GHES vs Dotcom) when constructing the Octokit REST client