Support variadic exists and exists? #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redis-rb 4.2.0 made `exists` variadic and introduced `exists?`
|
Missed #169 but the tests could be merged. |
|
Any chance we can get this merged and a new version released soon? |
Closed
|
Ping @rafaelfranca |
|
Ok for But what about: Edit: |
|
Any idea on the ETA for this? |
|
Seems this gem isn't being actively maintained anymore :( |
|
fwiw, this is my patch in a Rails initializer require 'redis/namespace'
if Redis::Namespace::NAMESPACED_COMMANDS.key?("exists?")
raise "Redis::Namespace now supports variadac exists, yay!"
else
# https://github.com/resque/redis-namespace/pull/171/files
Redis::Namespace::NAMESPACED_COMMANDS["exists?"] = [ :all ]
Redis::Namespace::COMMANDS["exists?"] = [ :all ]
end |
|
@bf4 Does this workaround work for you? I added # config/initializers/0_redis_namespace.rb
require 'redis/namespace'
if Redis::Namespace::NAMESPACED_COMMANDS.key?("exists?")
raise "Redis::Namespace now supports variadac exists, yay!"
else
# https://github.com/resque/redis-namespace/pull/171/files
Redis::Namespace::NAMESPACED_COMMANDS["exists?"] = [ :all ]
Redis::Namespace::COMMANDS["exists?"] = [ :all ]
endThis is how I use Redis::Namespace # config/initializers/redis.rb
redis_connection = Redis.new(url: Secret.sidekiq_redis_url, timeout: 5)
namespace = "#{Secret.app_namespace}:#{Rails.env}:web"
REDIS_WEB = Redis::Namespace.new(namespace, redis: redis_connection)when I open rails console I get error And when starting sidekiq then I get stack level too deep as well :/ I tried to use code from this PR directly in my app and it works fine # Gemfile
gem 'redis-namespace', github: 'Tolsto/redis-namespace', branch: 'feature/new-exists-api' |
|
@ArturT class Redis::Namespace
MY_HACKY_COMMANDS = {
'exists' => [:all],
'exists?' => [:all]
}
NAMESPACED_COMMANDS.reverse_merge! MY_HACKY_COMMANDS
COMMANDS.reverse_merge! MY_HACKY_COMMANDS
MY_HACKY_COMMANDS.keys.each do |command|
next if method_defined?(command)
define_method(command) do |*args, &block|
call_with_namespace(command, *args, &block)
end
end
end |
|
@al Thank you! It works. I added an exception when a new redis-namespace gem version will be released. # config/initializers/redis.rb
# start of workaround
# https://github.com/resque/redis-namespace/pull/171#issuecomment-670917998
if Redis::Namespace::NAMESPACED_COMMANDS.key?("exists?")
raise "Redis::Namespace now supports variadac exists, you can remove below workaround!"
end
class Redis::Namespace
MY_HACKY_COMMANDS = {
'exists' => [:all],
'exists?' => [:all]
}
NAMESPACED_COMMANDS.reverse_merge!(MY_HACKY_COMMANDS)
COMMANDS.reverse_merge!(MY_HACKY_COMMANDS)
MY_HACKY_COMMANDS.keys.each do |command|
next if method_defined?(command)
define_method(command) do |*args, &block|
call_with_namespace(command, *args, &block)
end
end
end
# end of workaround |
|
#169 was merged, this can be closed now. |
6 tasks
yasuman
added a commit
to yasuman/sidekiq
that referenced
this pull request
Jan 10, 2021
yasuman
added a commit
to yasuman/sidekiq
that referenced
this pull request
Jan 10, 2021
yasuman
added a commit
to yasuman/sidekiq
that referenced
this pull request
Jan 10, 2021
|
Can someone grant similar workaround for |
Not sure I follow. I don't see a |
|
I'm talking about the second warning in this comment while running Sidekiq, I got the same: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redis-rb 4.2.0 made
existsvariadic and introducedexists?