Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redis initializer to prevent deprecation warning being displayed #2018

Merged
merged 1 commit into from Nov 19, 2020

Conversation

mpw5
Copy link
Contributor

@mpw5 mpw5 commented Nov 18, 2020

What

Changes to the redis gem were causing deprecation warnings to be constantly displayed by sidekiq. We added a redis initializer to suppress those warnings.

The issue with redis has subsequently been fixed however our initializer is now causing the deprecation warning to be displayed when running eg rspec or cucumber from the command line:

image

Removing the initializer prevents the deprecation warning from being displayed on the command line and does not reintroduce the warning to sidekiq.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase master.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

Changes to the redis gem were causing deprecation warnings to be
constantly displayed by sidekiq. We added a redis initializer to
suppress those warnings.

The issue with redis has subsequently been fixed however our initializer
is now causing the deprecation warning to be displayed when running eg
rspec or cucumber from the command line.

Removing the initializer prevents the deprecation warning from being
displayed on the command line and does not reintroduce the warning to
sidekiq.
@mpw5 mpw5 added the ready for review Please review label Nov 18, 2020
@mpw5 mpw5 merged commit 4beb2a7 into master Nov 19, 2020
@mpw5 mpw5 deleted the fix-redis-exists-deprecation-warning branch November 19, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants