Does not raise error when it has invalid thumbails data (#65) #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! 002b903 |
|
I'm not sure if you noticed, but the build in Circle CI seems to be broken for a while -> https://app.circleci.com/pipelines/github/remvee/exifr |
julik
pushed a commit
to WeTransfer/format_parser
that referenced
this pull request
Sep 11, 2020
Closes #157 related to remvee/exifr#66 Before this update: ```bash $ exe/format_parser_inspect broken_thumbnails.jpg Traceback (most recent call last): 30: from exe/format_parser_inspect:22:in `<main>' 29: from exe/format_parser_inspect:22:in `map' 28: from exe/format_parser_inspect:24:in `block in <main>' 27: from exe/format_parser_inspect:24:in `public_send' 26: from /Users/fabioperrella/projects/format_parser/lib/format_parser.rb:105:in `parse_file_at' 25: from /Users/fabioperrella/projects/format_parser/lib/format_parser.rb:105:in `open' 24: from /Users/fabioperrella/projects/format_parser/lib/format_parser.rb:106:in `block in parse_file_at' 23: from /Users/fabioperrella/projects/format_parser/lib/format_parser.rb:174:in `parse' ... ``` After this update: ```bash $ exe/format_parser_inspect broken_thumbnails.jpg [ { "source_path_or_url": "broken_thumbnails.jpg", "options": { "results": "first" }, "result": { "nature": "image", "format": "jpg", "width_px": 1600, "height_px": 1200, "display_width_px": 1600, "display_height_px": 1200, "has_multiple_frames": null, "orientation": "top_left", "has_transparency": null, "color_mode": null, ... ```
|
Yes, I know.. :-( I gave up circleci a while ago (8257fad) when I had to upgrade the recipes again; had a setup to cover Ruby 1.8.7 up to whatever was hot at that moment, too much work to maintain. Not sure how to get rid of those annoying red x-es. Github actions is on my todo, not sure how to do multiple version of Ruby yet..
|
|
@remvee For how to do multiple versions of Ruby in GitHub Actions, see the README for ruby/setup-ruby, which includes a version matrix example. |
|
@ferdnyc thanks for the tip! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #65
As I told you before, I don't have the permission, for now, to share the customer file, but I can show the test that I wrote here:
I don't know how to generate a file to reproduce that error or even a good way to mock/stub a file for this test (I noticed that there are no mocks in the tests, which I like!)