Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken getting started links on README #9247

Merged
merged 2 commits into from Sep 14, 2022
Merged

Conversation

btav
Copy link
Contributor

@btav btav commented Sep 14, 2022

馃憢 At the moment, the getting started tutorial links on the package README.md are pointing to a docs/getting-started/ directory that no longer exists. As a result, users viewing the package on NPM will be pointed to a broken getting started link.

I have changed it to point to docs/start/.

Question, previously the react-router-dom and react-router-native pointed to the same tutorial, should this still be the case?

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2022

鈿狅笍 No Changeset found

Latest commit: 2273ca7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 14, 2022

Hi @btav,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 14, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 馃コ

@timdorr
Copy link
Member

timdorr commented Sep 14, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants