Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: React Router Dom NPM package (6.4.2) 'Getting Started Guide' Tutorial link is broken #9471

Closed
mdarif opened this issue Oct 17, 2022 · 2 comments
Labels

Comments

@mdarif
Copy link

mdarif commented Oct 17, 2022

What version of React Router are you using?

6.4.2

Steps to Reproduce

  1. Open the React Router Dom 6.4.2. npm package from https://www.npmjs.com/package/react-router-dom/v/6.4.2
  2. Click on the Getting Started guide
  3. You get 404 page not found because actual URL has been changed/updated.

Expected Behavior

React Router Dom NPM package (6.4.2) should have the right Getting Started guide link to land on the expected URL (https://github.com/remix-run/react-router/blob/main/docs/start/tutorial.md) rather the current wrong one.

Actual Behavior

  1. Open the React Router Dom 6.4.2. npm package from https://www.npmjs.com/package/react-router-dom/v/6.4.2
  2. Click on the Getting Started guide
  3. Tutorial.md should be opened from remix-run repo.
@mdarif mdarif added the bug label Oct 17, 2022
@mdarif mdarif changed the title [Bug]: React Router Dom NPM package 'Getting Started Guide' Tutorial link is broken [Bug]: React Router Dom NPM package (6.4.2) 'Getting Started Guide' Tutorial link is broken Oct 17, 2022
@timdorr
Copy link
Member

timdorr commented Oct 17, 2022

This was already fixed on main via #9247, so it should show up in the next release.

@timdorr timdorr closed this as completed Oct 17, 2022
@mdarif
Copy link
Author

mdarif commented Oct 17, 2022

Awesome @timdorr

Thanks for the quick confirmation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants