pyrsistent install fails on py2.7 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanpm
requested changes
Feb 2, 2021
There was a problem hiding this comment.
Could we please use a constraints file instead? Here's an example how we solve this kind of problem in another project:
- add a constraints file defining old versions of libraries, only for those which need it: https://github.com/release-engineering/pubtools-pulplib/blob/master/constraints-legacy.txt
- in tox.ini, for the python 2 configuration only, apply the constraints file: https://github.com/release-engineering/pubtools-pulplib/blob/master/tox.ini#L9
The advantage is that you end up only using the older version of the dependency for the python version which actually needs it, while other configs are still able to use latest released versions. It helps ensure that the code is able to work with both old and modern versions of deps rather than just one or the other.
The python2.7 installation of pyresistent (a jsonschema dependency) fails with the following error message: "pyrsistent requires Python '>=3.5' but the running Python is 2.7.15" Pyrsistent reportedly dropped python2.7 support [1]. Py2.7 installs of jsonschema must pin the latest pyresistent version with python2.7 support (pyrsistent-0.16.1) to avoid an installation error. This commit also introduces the constraints-legacy.txt file, which contains dependencies specific to python2.7. [1] tobgu/pyrsistent#208
crungehottman
force-pushed
the
pyrsistent
branch
from
0bac363
to
a2aba3c
Compare
rohanpm
approved these changes
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The python2.7 installation of pyresistent (a jsonschema dependency)
fails with the following error message:
"pyrsistent requires Python '>=3.5' but the running Python is 2.7.15"
Pyrsistent reportedly dropped python2.7 support [1]. Py2.7 installs
of jsonschema must pin the latest pyresistent version with python2.7
support (pyrsistent-0.16.1) to avoid an installation error.
[1] tobgu/pyrsistent#208