Create cdn_definitions.api module [RHELDST-4862] #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crungehottman |
The cdn_definitions.api module allows clients to consume the data.json or the schema.json files via a convenient API. This commit also introduces an optional "source" argument to the data_loads method. The source argument allows the user to specify the source of the cdn_definitions data.json file. The source could be a URL or a local path on a directory tree. If a source is not specified, the location may be overriden via the CDN_DEFINITIONS_PATH environment variable, which also may either be in the form of a URL or a local path.
crungehottman
force-pushed
the
RHELDST-4862
branch
from
4b56e12
to
dd86a74
Compare
PR for deps fix: #20 |
|
Do you just want to close this since it's included in #19 ? I don't have a problem reviewing them both together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cdn_definitions.api module allows clients to consume the
data.json or the schema.json files via a convenient API.
This commit also introduces an optional "source" argument to the
data_loads method. The source argument allows the user to specify
the source of the cdn_definitions data.json file. The source could
be a URL or a local path on a directory tree. If a source is not
specified, the location may be overriden via the
CDN_DEFINITIONS_PATH environment variable, which also may either
be in the form of a URL or a local path.