Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correctly mention bot accounts in release notes #1376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jan 3, 2024

  1. Fix: Correctly mention bot accounts in release notes

    As noted in release-drafter#60, bot accounts are currently being mis-mentioned, where
    instead of linking through to `dependabot[bot]` it'll tag a user
    `@dependabot` which isn't the same, and can result in unwanted
    notifications.
    
    To address this, we can retrieve the type of user that has authored a
    Pull Request, looking at the `__typename` to determine if it's a `Bot`
    or a `User` account, and provide a Markdown link to the Bot account's
    app page.
    
    Unfortunately this may result in a name such as:
    
        @[dependabot[bot]](https://github.com/apps/dependabot)
    
    But this is a better result than tagging the wrong account.
    
    Closes release-drafter#60.
    jamietanna committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    8b04f12 View commit details
    Browse the repository at this point in the history