Fix: Correctly mention bot accounts in release notes #1376
+73
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamietanna
changed the title
jamietanna
changed the title
As noted in release-drafter#60, bot accounts are currently being mis-mentioned, where instead of linking through to `dependabot[bot]` it'll tag a user `@dependabot` which isn't the same, and can result in unwanted notifications. To address this, we can retrieve the type of user that has authored a Pull Request, looking at the `__typename` to determine if it's a `Bot` or a `User` account, and provide a Markdown link to the Bot account's app page. Unfortunately this may result in a name such as: @[dependabot[bot]](https://github.com/apps/dependabot) But this is a better result than tagging the wrong account. Closes release-drafter#60.
jamietanna
force-pushed
the
feature/bot-accounts
branch
from
8dff34a
to
8b04f12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #60, bot accounts are currently being mis-mentioned, where
instead of linking through to
dependabot[bot]it'll tag a user@dependabotwhich isn't the same, and can result in unwantednotifications.
To address this, we can retrieve the type of user that has authored a
Pull Request, looking at the
__typenameto determine if it's aBotor a
Useraccount, and provide a Markdown link to the Bot account'sapp page.
Unfortunately this may result in a name such as:
@dependabot[bot]
But this is a better result than tagging the wrong account.
Closes #60.