Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use API for bypass-checks #3629

Merged
merged 10 commits into from Oct 9, 2020
Merged

Use API for bypass-checks #3629

Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
39e9997
Use api for `bypass-checks`
yakov116 Oct 7, 2020
c1dc13f
getRepoURL()
yakov116 Oct 7, 2020
9509fa3
YO! Will ya stop hardcoding github.com!!?!
yakov116 Oct 8, 2020
4e84493
Update source/features/bypass-checks.tsx
yakov116 Oct 8, 2020
ba66ba2
Update source/features/bypass-checks.tsx
yakov116 Oct 8, 2020
01b0f0f
Apply suggestions from code review
yakov116 Oct 8, 2020
80cfa4e
Fix
yakov116 Oct 8, 2020
15b16e1
Inline
yakov116 Oct 8, 2020
183e2a5
Remove unnecessary number
yakov116 Oct 9, 2020
173f6e4
Lint
yakov116 Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 10 additions & 9 deletions source/features/bypass-checks.tsx
View file
Open in desktop
@@ -1,19 +1,20 @@
import mem from 'mem';
import onetime from 'onetime';
import {observe} from 'selector-observer';
import * as pageDetect from 'github-url-detection';

import features from '.';
import fetchDom from '../helpers/fetch-dom';
import * as api from '../github-helpers/api';
import {getRepoURL} from '../github-helpers';

async function bypass(detailsLink: HTMLAnchorElement): Promise<void> {
const directLink = await fetchDom<HTMLAnchorElement>(
detailsLink.href,
'[data-hydro-click*="check_suite.external_click"]'
);
const getDirectLink = mem(async (runId: number): Promise<string> => {
Copy link
Member

@fregante fregante Oct 8, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API is already memoized, no need to do it again. You can probably just inline it like it was

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/sindresorhus/refined-github/blob/022e418940b98f7dfa7f4e2c532b2b83782ca45a/source/features/deep-reblame.tsx#L16

I keep doing it since I remember from here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be removed from there too. It would only make sense if it saved heavy operations (e.g. HTTP requests), but what follows is just a few conditions.

const directLink = await api.v3(`repos/${getRepoURL()}/check-runs/${runId}`);
return directLink.details_url;
});

if (directLink) {
detailsLink.href = directLink.href;
}
async function bypass(detailsLink: HTMLAnchorElement): Promise<void> {
const runId = new URLSearchParams(detailsLink.href).get('check_run_id') ?? detailsLink.pathname.split('/').pop();
yakov116 marked this conversation as resolved.
Show resolved Hide resolved
detailsLink.href = await getDirectLink(Number(runId));
}

function init(): void {
Expand Down