Use API for bypass-checks
#3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔥 |
fregante
reviewed
Oct 7, 2020
fregante
reviewed
Oct 8, 2020
Co-authored-by: Federico <me@fregante.com>
This comment has been minimized.
This comment has been minimized.
fregante
reviewed
Oct 8, 2020
source/features/bypass-checks.tsx
Outdated
| detailsLink.href, | ||
| '[data-hydro-click*="check_suite.external_click"]' | ||
| ); | ||
| const getDirectLink = mem(async (runId: number): Promise<string> => { |
There was a problem hiding this comment.
The API is already memoized, no need to do it again. You can probably just inline it like it was
There was a problem hiding this comment.
I keep doing it since I remember from here
There was a problem hiding this comment.
It can be removed from there too. It would only make sense if it saved heavy operations (e.g. HTTP requests), but what follows is just a few conditions.
fregante
reviewed
Oct 8, 2020
fregante
reviewed
Oct 9, 2020
source/features/bypass-checks.tsx
Outdated
| detailsLink.href = directLink.href; | ||
| } | ||
| const runId = new URLSearchParams(detailsLink.search).get('check_run_id') ?? detailsLink.pathname.split('/').pop(); | ||
| const directLink = await api.v3(`repos/${getRepoURL()}/check-runs/${Number(runId)}`); |
There was a problem hiding this comment.
Why number? It goes into a string.
There was a problem hiding this comment.
Sorry I have no idea why I did that!
fregante
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINKED ISSUES:
Dont remember which issue
TEST URLS:
Enable automatic annotations on GitHub Actions xojs/xo#497
Do not throw on custom stack traces sindresorhus/got#1491
feat(Stats): recursively get warnings or errors of a stats and its children webpack/webpack#11438
SCREENSHOT:
None