Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #3168

Merged
merged 10 commits into from Jun 3, 2020
Merged

Upgrade dependencies #3168

merged 10 commits into from Jun 3, 2020

Conversation

sindresorhus
Copy link
Member

No description provided.

.xo-config.js Outdated Show resolved Hide resolved
.xo-config.js Outdated Show resolved Hide resolved
.xo-config.js Outdated Show resolved Hide resolved
@fregante fregante added the meta Related to Refined GitHub itself label Jun 3, 2020
.xo-config.js Show resolved Hide resolved
.xo-config.js Show resolved Hide resolved
.xo-config.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
source/features/center-reactions-popup.css Show resolved Hide resolved
source/features/first-published-tag-for-merged-pr.tsx Outdated Show resolved Hide resolved
source/features/parse-backticks.css Show resolved Hide resolved
source/github-helpers/github-url.ts Show resolved Hide resolved
@sindresorhus
Copy link
Member Author

"target": "es2018", => "target": "es2020",?

@fregante
Copy link
Member

fregante commented Jun 3, 2020

I'm not entirely sure though, it's worth trying out the extension in both browsers. I think it's as easy as loading it: if it works without errors (content, options, background), then the browser supports the syntax

.xo-config.js Show resolved Hide resolved
.xo-config.js Show resolved Hide resolved
sindresorhus and others added 2 commits June 3, 2020 21:09
Co-authored-by: Fregante <opensource@bfred.it>
source/options.tsx Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Member Author

Webpack errors a lot when I change the output target:

ERROR in ./source/features/linkify-symbolic-links.tsx 7:29
Module parse failed: Unexpected token (7:29)
File was processed with these loaders:
 * ./node_modules/ts-loader/index.js
You may need an additional loader to handle the result of these loaders.
| import features from '.';
| function init() {
>     if (select('.file-mode')?.textContent === 'symbolic link') {
|         const line = select('.js-file-line');
|         wrap(line.firstChild, React.createElement("a", { href: line.textContent }));

I think that can be done later.

source/features/index.tsx Show resolved Hide resolved
source/options.tsx Outdated Show resolved Hide resolved
@fregante
Copy link
Member

fregante commented Jun 3, 2020

Webpack errors a lot when I change the output target:

Apparently due to acornjs/acorn#891

Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go. I'll open a new PR for the 2 things I mentioned: reduce and options’ init

sindresorhus and others added 2 commits June 3, 2020 21:32
Co-authored-by: Fregante <opensource@bfred.it>
@yakov116
Copy link
Member

Webpack errors a lot when I change the output target:

Apparently due to acornjs/acorn#891

https://github.com/webpack/webpack/releases/tag/v5.0.0-beta.18 includes the acorn update

yakov116 added a commit that referenced this pull request Apr 25, 2021
Disabled "@typescript-eslint/no-non-null-assertion": not compatible with DOM
Disabled " @typescript-eslint/no-non-null-asserted-optional-chain"  See #3093 (comment) and #3168 (comment)
@yakov116 yakov116 mentioned this pull request Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to Refined GitHub itself
Development

Successfully merging this pull request may close these issues.

None yet

3 participants