Lint #4276

yakov116 · 2021-04-25T12:52:06Z

Disabled "@typescript-eslint/no-non-null-assertion": not compatible with DOM
Disabled "@typescript-eslint/no-non-null-asserted-optional-chain" See #3093 (comment) and #3168 (comment)

Need typescript help
@typescript-eslint/no-unsafe-argument All but 2 are this issue. If you show me how to fix one I can do the rest.

Disabled "@typescript-eslint/no-non-null-assertion": not compatible with DOM Disabled " @typescript-eslint/no-non-null-asserted-optional-chain" See #3093 (comment) and #3168 (comment)

fregante

What fixed .closest’s types?

source/features/no-duplicate-list-update-time.tsx

source/options.tsx

source/features/file-finder-buffer.tsx

fregante · 2021-04-25T13:16:38Z

.xo-config.json

@@ -16,6 +16,8 @@
 		"no-void": "off",
 		"react/jsx-key": "off",
 		"unicorn/no-array-callback-reference": "off",
+		"@typescript-eslint/no-non-null-assertion": "off",
+		"@typescript-eslint/no-non-null-asserted-optional-chain": "off",


What's the problem again? It worked until now and typescript-eslint/typescript-eslint#1976 was resolved

Same issue, XO re enabled the rule now.

Disabled "@typescript-eslint/no-non-null-asserted-optional-chain" See #3093 (comment) and #3168 (comment)

If Sindre re-enabled them they're probably working now, so maybe our code is wrong.

The only reason I can think of to disable these are if the changes required just clutter the code without actually improving it

@typescript-eslint/no-non-null-assertion is correct in being disabled, we need those errors.

I'm checking the other one

@typescript-eslint/no-non-null-asserted-optional-chain should probably not be disabled.

However I'm not liking most of the type changes in this PR so I'd rather avoid all of them until a TS developer can review them properly.

If you're going to update XO:

disable no-unsafe-argument + a TODO to review later

disable no-non-null-asserted-optional-chain + same TODO

disable no-non-null-assertion with a comment that we need those runtime errors

@fregante in case you missed this comment

Find a JSON to YML converter and rename the file to .yml instead of .json

That did not work.

I am going to revert the Type's and just update dep excluding xo

You're right, I assumed it worked since ESLint supports it: xojs/xo#536

We are using a JSON file which makes it not possible to leave a comment.

That's not entirely true: https://github.com/sindresorhus/sindre-playground/blob/565ba9c61dbf4b13d587bcae7047120952f924c5/package.json#L26-L31

fregante · 2021-04-25T13:18:01Z

Need typescript help

There are a million type issues, can't open a PR and ask me to fix them. Just leave things unchanged

yakov116 · 2021-04-25T13:46:02Z

There are a million type issues, can't open a PR and ask me to fix them. Just leave things unchanged

@typescript-eslint/no-unsafe-argument All but 2 are this issue. If you show me how to fix one I can do the rest.

Sorry I wanted to update the first post I did not think you would review so fast 😄

yakov116 · 2021-04-25T13:46:51Z

What fixed .closest’s types

Its not fixed.

fregante · 2021-04-25T14:48:55Z

What fixed .closest’s types

Its not fixed.

I see that <HTMLElement> is being dropped from all. Why? If it works without, that's what I mean by "fixed"

yakov116 · 2021-04-25T14:49:41Z

I see that <HTMLElement> is being dropped from all. Why? If it works without, that's what I mean by "fixed"

I am going to work on it. That part is not ready yet.

fregante · 2021-04-26T09:11:44Z

If this PR makes it for May 1st, can you revert #4222 in here due to #4275?

yakov116 · 2021-04-26T09:17:17Z

If this PR makes it for May 1st, can you revert #4222 in here due to #4275?

Sure

fregante · 2021-04-26T15:02:47Z

I wish could could change some global types, but adding this to global.d.ts doesn't work 😩

interface Object {
	keysa<T, K extends keyof T>(o: T): K[];
}

interface JSON {
	parse(text: string, reviver?: (this: any, key: string, value: any) => any): JsonValue;
}

// and also Response#json()

source/features/show-associated-branch-prs-on-fork.tsx

source/features/stop-redirecting-in-notification-bar.tsx

.xo-config.json

This reverts commit 265c8fa.

fregante

Other than the outstanding reviews, it looks good so far, except I haven't tested it

source/features/release-download-count.tsx

source/globals.d.ts

sindresorhus · 2021-05-04T17:29:39Z

source/features/list-prs-for-file.tsx

@@ -61,7 +61,7 @@ function getSingleButton(prNumber: number, _?: number, prs?: number[]): HTMLElem
 const getPrsByFile = cache.function(async (): Promise<Record<string, number[]>> => {
 	const {repository} = await api.v4(`
 		repository() {
-			pullRequests(
+			pullRequests (


I added on purpose it looked wrong without a space and the arguments on a new line.

I can revert if you feel it wrong

We don't do this anywhere in the code and also doesn't match the function call style in XO. Reverted

yakov116 · 2021-05-06T02:52:21Z

@fregante can we disable clean-conversation-sidebar in this PR?

fregante · 2021-05-06T03:50:12Z

Ok

fregante

Should be good to go after this

source/features/release-download-count.tsx

yakov116 · 2021-05-06T04:13:27Z

@fregante can we disable clean-conversation-sidebar in this PR?

Hey looks like the "disabled" feature was removed. https://github.com/sindresorhus/refined-github/pull/3678/files#diff-cb1dafea7a9c68c5c2ebb2d56f749b3506c13f7d26feeaf56c86521b25c60358 🤔

fregante · 2021-05-06T06:31:41Z

Second bullet point in that PR #3678

Just comment out the import clean-conversation-sidebar line in refined-github.ts. It might be worth adding this piece of information at the top of the file.

#4258

Follows #4276

yakov116 added 3 commits April 25, 2021 07:54

Lint

d138202

Disabled "@typescript-eslint/no-non-null-assertion": not compatible with DOM Disabled " @typescript-eslint/no-non-null-asserted-optional-chain" See #3093 (comment) and #3168 (comment)

Move get-current-committish to its own file

7e4e39d

Some more lint

8f10741

yakov116 requested a review from fregante April 25, 2021 12:52

fregante reviewed Apr 25, 2021

View reviewed changes

fregante added the meta Related to Refined GitHub itself label Apr 25, 2021

yakov116 added 3 commits April 25, 2021 23:40

Fix some more types

bb28903

Revert .closest

d5a06d1

Fix 2 more

3ca191d

Make the tests pass for now

45242b1

Fix some types

a0e618e

yakov116 commented Apr 26, 2021

View reviewed changes

source/features/show-associated-branch-prs-on-fork.tsx Outdated Show resolved Hide resolved

yakov116 added 9 commits April 26, 2021 22:56

Hack it

02c9672

Fix one more

0075d18

Restore convert-release-to-draft.tsx

55cb73a

Restore file-finder-buffer.tsx

5bc6a8b

Restore index.tsx

1d04c6e

Restore options.tsx

3d657a1

Small type fix

44d1aa6

Revert fix-teaxtarea

b0b3166

unicorn/expiring-todo-comments: warn

3461b7e

fregante reviewed Apr 27, 2021

View reviewed changes

source/features/stop-redirecting-in-notification-bar.tsx Outdated Show resolved Hide resolved

fregante reviewed May 4, 2021

View reviewed changes

.xo-config.json Outdated Show resolved Hide resolved

yakov116 added 10 commits May 4, 2021 05:37

convert to yml

265c8fa

Merge branch 'main' into lint

3116544

Revert "convert to yml"

32af8df

This reverts commit 265c8fa.

Correct Type

b775d52

And some more

a2cf78c

Restore .xo-config.json

d97d253

Update

d2d5c0d

Update excluding xo

2215257

Restore quick-repo-deletion.tsx

c2b4f6d

Lint

d83acea

fregante reviewed May 4, 2021

View reviewed changes

source/features/release-download-count.tsx Outdated Show resolved Hide resolved

source/globals.d.ts Outdated Show resolved Hide resolved

sindresorhus reviewed May 4, 2021

View reviewed changes

yakov116 added 6 commits May 5, 2021 05:31

Restore globals.d.ts

37b5734

Restore vertical-front-matter.tsx

43c007a

Update some more

05cf4ad

Restore mark-merge-commits-in-list.tsx

3761225

Merge remote-tracking branch 'upstream/lint' into lint

22b4592

One last attempt at the types

0c93073

yakov116 marked this pull request as ready for review May 6, 2021 02:51

fregante reviewed May 6, 2021

View reviewed changes

source/features/release-download-count.tsx Show resolved Hide resolved

fregante added 2 commits May 6, 2021 14:27

Disable clean-conversation-sidebar

a87d50d

#4258

Restore list-prs-for-file.tsx

db29dba

fregante merged commit 2fc61cf into main May 6, 2021

fregante deleted the lint branch May 6, 2021 07:39

fregante added a commit that referenced this pull request May 10, 2021

Restore stop-redirecting-in-notification-bar

875d6ec

Follows #4276

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Lint #4276

Lint #4276

yakov116 commented Apr 25, 2021 •

edited

fregante left a comment

fregante Apr 25, 2021

yakov116 Apr 25, 2021 •

edited

fregante Apr 25, 2021

fregante Apr 26, 2021

fregante Apr 26, 2021

yakov116 Apr 29, 2021

fregante May 4, 2021 •

edited

yakov116 May 4, 2021 •

edited

fregante May 4, 2021

sindresorhus May 4, 2021

fregante commented Apr 25, 2021 •

edited

yakov116 commented Apr 25, 2021

yakov116 commented Apr 25, 2021

fregante commented Apr 25, 2021

yakov116 commented Apr 25, 2021

fregante commented Apr 26, 2021

yakov116 commented Apr 26, 2021

fregante commented Apr 26, 2021

fregante left a comment

sindresorhus May 4, 2021

yakov116 May 4, 2021

fregante May 6, 2021

yakov116 commented May 6, 2021

fregante commented May 6, 2021 •

edited

fregante left a comment

yakov116 commented May 6, 2021

fregante commented May 6, 2021 •

edited

Lint #4276

Lint #4276

Conversation

yakov116 commented Apr 25, 2021 • edited

fregante left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yakov116 Apr 25, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fregante May 4, 2021 • edited

Choose a reason for hiding this comment

yakov116 May 4, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fregante commented Apr 25, 2021 • edited

yakov116 commented Apr 25, 2021

yakov116 commented Apr 25, 2021

fregante commented Apr 25, 2021

yakov116 commented Apr 25, 2021

fregante commented Apr 26, 2021

yakov116 commented Apr 26, 2021

fregante commented Apr 26, 2021

fregante left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yakov116 commented May 6, 2021

fregante commented May 6, 2021 • edited

fregante left a comment

Choose a reason for hiding this comment

yakov116 commented May 6, 2021

fregante commented May 6, 2021 • edited

yakov116 commented Apr 25, 2021 •

edited

yakov116 Apr 25, 2021 •

edited

fregante May 4, 2021 •

edited

yakov116 May 4, 2021 •

edited

fregante commented Apr 25, 2021 •

edited

fregante commented May 6, 2021 •

edited

fregante commented May 6, 2021 •

edited