Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag to disable raising exceptions with pipelined #1263

Merged

Conversation

philippeboyd
Copy link
Contributor

@philippeboyd philippeboyd commented Apr 10, 2024

Linked to redis-rb/redis-client#187
Depends on redis-rb/redis-cluster-client#343

Modifying the pipelined method in lib/redis_client.rb to include an optional exception parameter, which determines whether an exception should be raised when an error occurs during pipelining.

This gives better flexibility for error management when we want to retry only failed commands.

@philippeboyd philippeboyd force-pushed the feature/add-pipeline-raise_exception-flag branch 2 times, most recently from 2db6f18 to 30dc0eb Compare April 10, 2024 15:21
Gemfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@philippeboyd philippeboyd force-pushed the feature/add-pipeline-raise_exception-flag branch 6 times, most recently from eba0593 to 53e7951 Compare April 12, 2024 18:42
@supercaracal
Copy link
Contributor

Several errors and failures in test cases of the cluster feature will be fixed with the following PR.

Although there are some discussion about the transaction feature for the cluster client, the issue is a matter on the redis-cluster-client side. So redis-rb can ignore the discussion at now.

@philippeboyd philippeboyd force-pushed the feature/add-pipeline-raise_exception-flag branch from 53e7951 to 0b561b3 Compare April 15, 2024 14:09
@philippeboyd philippeboyd force-pushed the feature/add-pipeline-raise_exception-flag branch from 0b561b3 to 609b6bc Compare April 15, 2024 14:13
@philippeboyd philippeboyd marked this pull request as ready for review April 15, 2024 14:15
@byroot byroot merged commit b2f9c28 into redis:master Apr 15, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants