Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several test cases for the cluster feature #1264

Closed

Conversation

supercaracal
Copy link
Contributor

@supercaracal supercaracal commented Apr 12, 2024

This may be a bug in the redis-cluster-client side, but I think we can do workaround at now.
https://github.com/redis/redis-rb/actions/runs/8666570773/job/23768812497?pr=1263

  1) Error:
TestClusterClientInternals#test_acl_auth_success:
Redis::Cluster::InitialSetupError: Redis client could not fetch cluster information: NOPERM User johndoe has no permissions to run the 'readonly' command (redis://127.0.0.1:16380),WRONGPASS invalid username-password pair or user is disabled. (redis://127.0.0.1:16385),WRONGPASS invalid username-password pair or user is disabled. (redis://127.0.0.1:16384)
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster/node.rb:344:in `refetch_node_info_list'
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster/node.rb:209:in `block (2 levels) in reload!'
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster/node.rb:420:in `with_startup_clients'
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster/node.rb:208:in `block in reload!'
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster/node.rb:436:in `block in with_reload_lock'
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster/node.rb:433:in `synchronize'
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster/node.rb:433:in `with_reload_lock'
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster/node.rb:207:in `reload!'
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster/router.rb:312:in `update_cluster_info!'
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster/router.rb:26:in `initialize'
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster.rb:20:in `new'
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster.rb:20:in `initialize'
    cluster/lib/redis/cluster/client.rb:51:in `block in initialize'
    cluster/lib/redis/cluster/client.rb:105:in `handle_errors'
    cluster/lib/redis/cluster/client.rb:51:in `initialize'
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster_config.rb:74:in `new'
    vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.7.9/lib/redis_client/cluster_config.rb:74:in `new_client'
    cluster/lib/redis/cluster.rb:103:in `initialize_client'
    lib/redis.rb:73:in `initialize'
    cluster/lib/redis/cluster.rb:69:in `initialize'
    cluster/test/helper.rb:158:in `new'
    cluster/test/helper.rb:158:in `_new_client'
    cluster/test/client_internals_test.rb:59:in `block (2 levels) in test_acl_auth_success'
    test/helper.rb:179:in `with_acl'
    cluster/test/client_internals_test.rb:58:in `block in test_acl_auth_success'
    test/helper.rb:157:in `target_version'
    cluster/test/client_internals_test.rb:57:in `test_acl_auth_success'

The watch command behavior was changed in the redis-cluster-client side at the latest version.
https://github.com/redis/redis-rb/actions/runs/8668831551/job/23774590388?pr=1264

  1) Failure:
TestClusterCommandsOnTransactions#test_watch [cluster/test/commands_on_transactions_test.rb:41]:
CROSSSLOT Keys in request don't hash to the same slot.
[Redis::CommandError] exception expected, not
Class: <Redis::Cluster::TransactionConsistencyError>
Message: <"A block required. And you need to use the block argument as a client for the transaction.">
---Backtrace---
/home/runner/work/redis-rb/redis-rb/vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.8.0/lib/redis_client/cluster/router.rb:316:in `send_watch_command'
/home/runner/work/redis-rb/redis-rb/vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.8.0/lib/redis_client/cluster/router.rb:49:in `send_command'
/home/runner/work/redis-rb/redis-rb/vendor/bundle/ruby/2.7.0/gems/redis-cluster-client-0.8.0/lib/redis_client/cluster.rb:35:in `call_v'
/home/runner/work/redis-rb/redis-rb/cluster/lib/redis/cluster/client.rb:85:in `block in call_v'
/home/runner/work/redis-rb/redis-rb/cluster/lib/redis/cluster/client.rb:104:in `handle_errors'
/home/runner/work/redis-rb/redis-rb/cluster/lib/redis/cluster/client.rb:85:in `call_v'
/home/runner/work/redis-rb/redis-rb/lib/redis/commands/transactions.rb:63:in `block in watch'
/home/runner/work/redis-rb/redis-rb/lib/redis.rb:147:in `block in synchronize'
/home/runner/work/redis-rb/redis-rb/lib/redis.rb:147:in `synchronize'
/home/runner/work/redis-rb/redis-rb/lib/redis.rb:147:in `synchronize'
/home/runner/work/redis-rb/redis-rb/lib/redis/commands/transactions.rb:62:in `watch'
/home/runner/work/redis-rb/redis-rb/cluster/test/commands_on_transactions_test.rb:42:in `block in test_watch'

@supercaracal supercaracal changed the title Fix a test case for the cluster related to the permission issue Fix several test cases for the cluster feature Apr 12, 2024
@supercaracal
Copy link
Contributor Author

I forgot abount the following PR.

@supercaracal supercaracal deleted the fix-cluster-test-error branch April 12, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant