Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove non-ascii colon in JedisSentintelPool #2062

Closed
wants to merge 1 commit into from
Closed

Remove non-ascii colon in JedisSentintelPool #2062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/redis/clients/jedis/JedisSentinelPool.java
View file
Open in desktop
Expand Up @@ -287,8 +287,8 @@ public void run() {
*/
List<String> masterAddr = j.sentinelGetMasterAddrByName(masterName);
if (masterAddr == null || masterAddr.size() != 2) {
log.warn("Can not get master addr, master name: {}. Sentinel: {}：{}.",masterName,host,port);
}else{
log.warn("Can not get master addr, master name: {}. Sentinel: {}: {}.",masterName,host,port);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you add a white space? where is none ascii?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The colon is the non ascii character here, GitHub just renders it as such. Before ： after :

} else{
Comment on lines +290 to +291
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove wrongful and/or unnecessary spaces.

initPool(toHostAndPort(masterAddr));
}

Expand Down