Remove non-ascii colon in JedisSentintelPool #2062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkorland
approved these changes
Oct 15, 2019
gkorland
suggested changes
Oct 15, 2019
| @@ -287,8 +287,8 @@ public void run() { | |||
| */ | |||
| List<String> masterAddr = j.sentinelGetMasterAddrByName(masterName); | |||
| if (masterAddr == null || masterAddr.size() != 2) { | |||
| log.warn("Can not get master addr, master name: {}. Sentinel: {}：{}.",masterName,host,port); | |||
| }else{ | |||
| log.warn("Can not get master addr, master name: {}. Sentinel: {}: {}.",masterName,host,port); | |||
There was a problem hiding this comment.
why did you add a white space? where is none ascii?
There was a problem hiding this comment.
The colon is the non ascii character here, GitHub just renders it as such. Before ： after :
sazzad16
requested changes
Oct 27, 2019
Comment on lines
+290
to
+291
| log.warn("Can not get master addr, master name: {}. Sentinel: {}: {}.",masterName,host,port); | ||
| } else{ |
There was a problem hiding this comment.
Please remove wrongful and/or unnecessary spaces.
gkorland
approved these changes
Nov 25, 2019
|
@gkorland We should not merge this right now, in https://github.com/xetorthio/jedis/pull/2062/files#diff-e6525ac1a247b59a49332a6584030684R290 it changes |
|
@sazzad16 Ok I see your point, let's merge the other PR and close this one. |
sazzad16
added a commit
that referenced
this pull request
Nov 26, 2019
Details about this PR can be found in #2062 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This character will fail to compile unless compiled with the additional compiler option
-Dfile.encoding=UTF8